(Analytics Controller) Issues in sending csv email and adding proper error codes and swagger improvements #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekFitkariwala
requested changes
Jul 7, 2024
There was a problem hiding this comment.
400 and 500 should be listed for all the requests.
| user | ||
| ); | ||
| logger.info({ message: `Exported Data emailed successfully to ${email}` }); | ||
| try { |
There was a problem hiding this comment.
Try catch should only wrap sendEmail function
ppratikcr7
changed the title
ppratikcr7
changed the title
|
@VivekFitkariwala can we get an updated review on this so we can move towards resolving some of our older PRs? |
VivekFitkariwala
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending proper error codes in api response (500 instead of 400) for sending email and error code coverage in analytics controller swagger doc.
There was an error of "Missing final '@ domain'" due to a comma after the email id in env file. This PR resolves #1733